-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-86: Notification in channel on MR reopen #113
GH-86: Notification in channel on MR reopen #113
Conversation
CI is failing with the same error I was seeing with the dependency versions in the |
The build is failing because of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @ashishbhate -- just a suggestion to clean up the code a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending change request from @cpoile! Thanks, @ashishbhate!
Updated with switch instead of long if-else. Let me know if you need me to squash the two commits into a single commit. |
@ashishbhate can you please sync and merge with master to fix the build? |
@levb I've merged master into the branch |
This issue has been automatically labelled "stale" because it hasn't had recent activity. /cc @jasonblais @hanzei |
@DHaussermann Friendly reminder to help with QA review :) |
@levb this PR is still untested as I unable to build this. Let's follow-up so I can get assistance from someone on the team to see what's going on. |
Hi guys, let me know if there's anything I can do to help get this PR merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
Created a webhook and confirmed that re-opening a merge request delivers an event as expected
LGTM!
Thanks @ashishbhate for fixing this issue. Apologies for the delay on this one.
Send notification in channel on MR reopen. Fixes #86
I had to update my go.mod file to get the plugin to work. I'm not sure if the CI needs it.
See messages starting from https://community.mattermost.com/core/pl/nj3bdn8b8ifjfp9r8w41frk84w