Skip to content

MM-67120: Upgrade mattermost-plugin-github webapp to React 18#963

Open
nevyangelova wants to merge 1 commit intomasterfrom
MM-67120
Open

MM-67120: Upgrade mattermost-plugin-github webapp to React 18#963
nevyangelova wants to merge 1 commit intomasterfrom
MM-67120

Conversation

@nevyangelova
Copy link

Summary

Upgrade from React 16 to React 18 and all necessary dependency updates.

  • React: 16.13.1 - 18.2.0
  • React DOM: 16.13.1 - 18.2.0
  • React Redux: 7.2.1 - 8.1.3
  • Redux: 4.0.5 - 4.2.1
  • react-select: 3.1.0 - 5.10.0
  • react-custom-scrollbars - react-custom-scrollbars-2: 4.5.0
  • Migrated from Enzyme to React Testing Library
  • Removed enzyme, enzyme-adapter-react-16, enzyme-to-json, cheerio
  • Updated Babel plugins from proposal-* to transform-* variants
  • Updated TypeScript types for React 18
  • Removed deprecated string refs from modal components
  • Updated react-select v5 API
  • Added react-bootstrap type declaration override for React 18 compatibility

Ticket Link

https://mattermost.atlassian.net/browse/MM-67120

@nevyangelova nevyangelova requested a review from a team as a code owner February 3, 2026 05:40
@nevyangelova nevyangelova added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Feb 3, 2026
Copy link
Contributor

@avasconcelos114 avasconcelos114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

"react-select": "3.1.0",
"redux": "4.0.5",
"react-redux": "8.1.3",
"react-select": "5.10.0",
Copy link
Member

@marianunez marianunez Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the others, this is a big jump on react-select so let's make sure to QA any dropdowns in the plugin modals @ogi-m

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Areas to cover based on the plugin UI:

Issue creation modal
Attach comment to issue modal
GitHub link tooltips
Sidebar buttons functionality
Repo/label/assignee selectors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants