GIthub Discussions and Discussion Comments Webhooks

[elewis787]

Summary

This pr adds basic support for GitHub discussions and discussion comment events.

Ticket Link

If this pull request addresses a Help Wanted ticket #480

Notes

I would love to hear thoughts on the template for both discussions and discussion comments. I did not add additional style or attempt to pull out a lot of information but I am happy to update the template as needed.

I also struggled with the playwrite test. If helpful, I am happy to further debug them and ensure they are working. I tested this manually using smee.io for webhook forwarding to a local deployment. I replayed the webhooks while testing.

test where done by integrated https://github.com/orgs/elewis787-org/discussions

I have attached a few screenshots to help demonstrate the functionality

[mattermost-build]

Hello @elewis787,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

[fmartingr]

Good work on the PR! No specific complaints but there are a few typos around.

Can you get some screenshots and add those to the PR summary?

[elewis787]

Good work on the PR! No specific complaints but there are a few typos around.

Can you get some screenshots and add those to the PR summary?

Thanks @fmartingr. Apologies for the spelling errors!

I have attached screenshots and a demo org/repository.

[fmartingr]

Thanks for the submission! I will request someone else's reviews to have more eyes on this and make sure it adheres to the plugin guidelines.

[fmartingr]

@elewis787 Can you check the lint errors?

[elewis787]

@elewis787 Can you check the lint errors?

I pushed a fix for the indentation error in the const block. I'm looking into if I can retrigger the ci lint check to verify I caught all of them. I am not seeing any other changes locally.

[raghavaggarwal2308]

@elewis787 Great work on this PR. Just added a few code refactoring comments

[hanzei]

@fmartingr There are already four other people who review the PR. If you don't mind, I prefer not to review the PR. Is that fine with you?

[raghavaggarwal2308]

@wiggin77 Can you please give this PR a review. Also, I have never worked on playwright tests,so not sure about the changes make in the playwright tests.

I see the package-lock.json shows edits - I can revert this as needed - these changes are a result of using an audit fix. I was not able to use the e2e test locally. I suspect that this is largely related to my local node version. I did not attempt to revert back to previous versions.

@elewis787 Yes, I think we can revert that

[elewis787]

@wiggin77 Can you please give this PR a review. Also, I have never worked on playwright tests,so not sure about the changes make in the playwright tests.

I see the package-lock.json shows edits - I can revert this as needed - these changes are a result of using an audit fix. I was not able to use the e2e test locally. I suspect that this is largely related to my local node version. I did not attempt to revert back to previous versions.

@elewis787 Yes, I think we can revert that

I have push a reverted package-lock.json for the e2e tests.

[wiggin77]

Great work @elewis787 👍

[mattermost-build]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

[mattermost-build]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

[elewis787]

Anything I can do to help push this forward?

[raghavaggarwal2308]

Anything I can do to help push this forward?

Hey @elewis787 ,
This PR is waiting for a approval from QA. We will try to get it reviewed ASAP.
Apologies for the delay.
cc: @AayushChaudhary0001

[elewis787]

Anything I can do to help push this forward?

Hey @elewis787 , This PR is waiting for a approval from QA. We will try to get it reviewed ASAP. Apologies for the delay. cc: @AayushChaudhary0001

Thank you! No rush. Please reach out if there is anything I can do to help.

[AayushChaudhary0001]

This PR has been tested and looks good. All the notifications regarding the new discussion creation and discussion comments are received on Mattermost. Approved.

Note:- Please add the change regarding the events(discussions, discussion comments) to be enabled in Github webhook for notifications of discussions and discussion comments in the readme file.

[raghavaggarwal2308]

@elewis787 Can you create a PR in the MM docs https://github.com/mattermost/docs repo for the documentation changes? I think the webhook configurations needed to be updated for this PR to work.

[elewis787]

Absolutely! I'll work on a write up.

[raghavaggarwal2308]

@elewis787 Thanks! Please let us know when the PR is created. We can merge this PR after that

[elewis787]

@raghavaggarwal2308 here are the minimal doc updates mattermost/docs#7371.

Please let me know if more details are needed.

[raghavaggarwal2308]

@elewis787 Awesome work on this PR. Thank you for your contribution.

[elewis787]

@raghavaggarwal2308 Thanks for all of your help with the reviews and direction! I am excited to see this merged.