[MM-53944] Make use of github.com/mattermost/mattermost/server/public #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
commented
Dec 19, 2023
There was a problem hiding this comment.
Removing as part of the sync with the starter template
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #725 +/- ##
=======================================
Coverage 15.79% 15.79%
=======================================
Files 15 15
Lines 5767 5767
=======================================
Hits 911 911
Misses 4814 4814
Partials 42 42 ☔ View full report in Codecov by Sentry. |
|
/update-branch |
mickmister
approved these changes
Dec 22, 2023
|
@Kshitij-Katiyar @raghavaggarwal2308 Could one of you please give the PR a review? Thanks! |
hanzei
requested review from
AayushChaudhary0001 and
ayusht2810
and removed request for
AayushChaudhary0001
raghavaggarwal2308
approved these changes
Jan 4, 2024
ayusht2810
approved these changes
Jan 4, 2024
|
Waiting for v2.2.0 to get released |
hanzei
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes use of the newly created go module in https://pkg.go.dev/github.com/mattermost/mattermost/server/public.
See mattermost/mattermost-plugin-demo#163 and mattermost/mattermost-plugin-gitlab#393 for similar migrations.
Ticket Link
https://mattermost.atlassian.net/browse/MM-53944