Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'. #683

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

  • Currently, subscriptions allow adding repositories or an organization to a subscription. Added an additional --exclude flag that will allow excluding repositories from the webhook notification.

  • Issue #418

* [MI-2874]: Added --exclude option to subscriptions commandx

* [MI-2874]:Updated the read me files

* [MI-2874]:Fixed review comments

* [MI-2874]:Fixed review comments

---------

Co-authored-by: Kshitij Katiyar <kshitij.katiyar@brightscout.com>
@Kshitij-Katiyar Kshitij-Katiyar changed the title [GH418-]: Fixed issue #418 'Added --exclude option to subscriptions command'. [GH418]: Fixed issue #418 'Added --exclude option to subscriptions command'. Jun 12, 2023
@mattermost-build
Copy link
Contributor

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (dcf1828) 15.63% compared to head (c1ce0fe) 15.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
- Coverage   15.63%   15.57%   -0.07%     
==========================================
  Files          15       15              
  Lines        5518     5541      +23     
==========================================
  Hits          863      863              
- Misses       4613     4636      +23     
  Partials       42       42              
Impacted Files Coverage Δ
server/plugin/command.go 8.03% <0.00%> (-0.07%) ⬇️
server/plugin/subscriptions.go 8.23% <0.00%> (-0.66%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Kshitij-Katiyar Kshitij-Katiyar changed the title [GH418]: Fixed issue #418 'Added --exclude option to subscriptions command'. [GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'. Jun 12, 2023
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

server/plugin/subscriptions.go Outdated Show resolved Hide resolved
server/plugin/subscriptions.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 20, 2023
@hanzei hanzei requested a review from crspeller June 20, 2023 17:29
@hanzei
Copy link
Contributor

hanzei commented Jun 20, 2023

@Kshitij-Katiyar Merging master might fix CI

@crspeller crspeller removed the 2: Dev Review Requires review by a core committer label Jun 27, 2023
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei hanzei linked an issue Sep 29, 2023 that may be closed by this pull request
@Kshitij-Katiyar Kshitij-Katiyar added this to the v2.3.0 milestone Oct 5, 2023
@hanzei hanzei removed the request for review from DHaussermann October 16, 2023 20:44
@hanzei hanzei mentioned this pull request Nov 9, 2023
@avas27JTG avas27JTG modified the milestones: v2.3.0, v2.2.0 Nov 13, 2023
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested "--exclude" flag in subscriptions and it's working fine, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --exclude option to subscriptions command
8 participants