-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make playwright tests run off of ci workflow run #681
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
=======================================
Coverage 15.63% 15.63%
=======================================
Files 15 15
Lines 5518 5518
=======================================
Hits 863 863
Misses 4613 4613
Partials 42 42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any playwright runs for this PR. Should they run for this PR?
@hanzei It could be because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
This step only runs on master or main @mickmister https://github.com/mattermost/actions-workflows/blob/main/.github/workflows/plugin-ci.yml#L78 Also workflow run events need to be commited to master first before they actually run on PRs for security reasons .
|
You are good to ship. I would suggest also adding an extra condition in order to check if if: github.event.workflow_run.conclusion == 'success' |
* [MI-2481]:Fixed issue #613 on github (#12) * [MI-2481]:Fixed issue #681 on github * [MI-2481]:Fixed review fixes * [MI-2481]:Fixed review fixes * [MI-2481]:Fixed review fixes * [MI-2547]:Fixed review fixes for Github issue 613 and PR 626 (#14) * [MI-2547]:Fixed review fixes for Github issue 613 and PR 626 * [MI-2547]:Fixed review fixes * [MI-2547]:Fixed review fixes * [MI-2582]:Fixed review comments for github issue #613 (#15) * [MM-613]:Fixed review comments * [MI-3072]:Converted the LHS APIs into GraphQL (#32) * [MI-3012]: Converted user PRs API into GraphQL * [MI-3012]: Fixed review comments * [MI-3012]:fixed log message * [MI-3035]: Converted the get assignment API into GraphQL * [MI-3035]:Fixed self review comments * [MI-3035]: Fixed review comments * [MI-3072]:Converted review requested API to graphQL * [MI-3072]:Combined all the graphQL queries * [MI-3072]:Fixed CI errors * [MI-3072]:Fixed review comments * [MI-3072]:Fixed CI errors * [MI-3072]:Fixed review comments * [MI-3072]:Fixed review comments * [MM-613]:Changed namings * [MM-613]:Fixed review comments * [MM-613]:Fixed review comments * [MM-613]:Fixed panic error * [MM-613]:Fixed review comments * [MM-613]:Fixed lint errors * [MM-613]:Fixed review comment * [MM-613]:Fixed review comments * [MM-613]:Fixed review comments
Summary
Playwright tests are currently failing for fork PRs. This PR solves this by running the workflow alongside the
ci
workflow, to access variables for the Mattermost project during the workflow run.Context https://community.mattermost.com/core/pl/buyo3qkq8tdm9yeobg6dsih4gy
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-53014