Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to external profile image and bump version to 0.9.1 #68

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

jwilander
Copy link
Member

@jwilander jwilander commented Apr 9, 2019

Copy link
Member

@crspeller crspeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why this doesn't work?

@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Apr 9, 2019
@jwilander jwilander merged commit dbc90c3 into master Apr 9, 2019
@jwilander jwilander deleted the profile-image-fix branch April 9, 2019 16:44
@jwilander
Copy link
Member Author

Sorry @crspeller, didn't answer your question. For some reason the image proxy on community was complaining about it, not really sure why because when I tested it locally it worked fine. I think I'd rather do this for now until we convert to use a proper bot account then just set the profile image of the bot account instead of using the props override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants