Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip notification for edit/delete of comments on issues #65

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Skip notification for edit/delete of comments on issues #65

merged 1 commit into from
Mar 25, 2019

Conversation

checkaayush
Copy link
Contributor

Fixes #55

@checkaayush
Copy link
Contributor Author

@hanzei Ready for review.

@hanzei hanzei requested review from jwilander and hanzei March 25, 2019 15:21
hanzei
hanzei approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Mar 25, 2019
@jwilander jwilander merged commit 20ac3df into mattermost:master Mar 25, 2019
@jwilander
Copy link
Member

Awesome, thanks @checkaayush !

@checkaayush checkaayush deleted the fixCommentEditNotif branch March 25, 2019 16:38
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilander jwilander jwilander approved these changes

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@checkaayush @jwilander @hanzei