Show author of PR/issue in link tooltip #597
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 15.63% 15.63%
=======================================
Files 15 15
Lines 5243 5243
=======================================
Hits 820 820
Misses 4380 4380
Partials 43 43 ☔ View full report in Codecov by Sentry. |
hanzei
added
2: Dev Review
There was a problem hiding this comment.
Awesome work @shinnlok! This looks great, I just have one request to use a link to the user's GitHub profile
| @@ -97,7 +105,7 @@ export const LinkTooltip = ({href, connected, show, theme}) => { | |||
| {data.repo} | |||
| </span> | |||
| {' on '} | |||
| <span>{date}</span> | |||
| <span>{date + authorText}</span> | |||
There was a problem hiding this comment.
Can we have the username be a clickable link to the user's GitHub profile?
There was a problem hiding this comment.
@mickmister Is this a blocking comment?
There was a problem hiding this comment.
@hanzei Yes this is a blocking comment
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
Hi @shinnlok, just checking in. Are you interested in implementing the piece mentioned in this comment? #597 (comment) Thanks for your hard work on this! |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
/update-branch |
hanzei
added
Awaiting Submitter Action
|
/update-branch |
hanzei
added
Lifecycle/3:orphaned
and removed
Awaiting Submitter Action
|
Closing due to inactivity |
Summary
Added author to the linked tooltip.
Issue:
Pull Request:
Ticket Link
Fixes #439