Only render tooltip on hover #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
=======================================
Coverage 19.64% 19.64%
=======================================
Files 11 11
Lines 2708 2708
=======================================
Hits 532 532
Misses 2138 2138
Partials 38 38 Continue to review full report at Codecov.
|
mickmister
approved these changes
Sep 18, 2020
larkox
approved these changes
Sep 21, 2020
DHaussermann
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
Tested and passed.
- Works as expected when corresponding webapp PR is in place
- No regressions found on older server versions
See mattermost/mattermost-webapp#6492 fore details.
LGTM!
hanzei
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make use of the
showprop added in mattermost/mattermost-webapp#6492 by only rendering the tooltip on hover. This means data is not longer pre-fetched. Therefore a small delay is visible when hovering. Please note, on re-hovering the link the tooltip is shown imminently. Switching channel caused the data to be lost and it's required to fetch is again. I opted for this approach because storing the data in redux would mean that we would have to clean it up from time to time and it's hard to figure out what data should be cleaned up.The change is backward compatible to
I did also simplify the existing code a bit.
Ticket Link
https://mattermost.atlassian.net/browse/MM-28591