Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Message Should be User Friendly #498

Closed
dipak-demansol opened this issue Oct 9, 2021 · 8 comments · Fixed by #764
Closed

Validation Message Should be User Friendly #498

dipak-demansol opened this issue Oct 9, 2021 · 8 comments · Fixed by #764
Assignees
Labels
Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Enhancement New feature or improvement of existing feature

Comments

@dipak-demansol
Copy link

validation is not user friendly

@hanzei hanzei added Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers labels Oct 9, 2021
@hanzei
Copy link
Contributor

hanzei commented Oct 9, 2021

This might need server side changes

@dipak-demansol dipak-demansol changed the title Validation Message is user Friendly Validation Message Should be User Friendly Oct 10, 2021
@adithyaakrishna
Copy link

adithyaakrishna commented Oct 25, 2021

@hanzei I'm not sure about Server Side Changes, how about if we show a general error something like 'Input Cannot be Empty'

We can probablycheck if the input is only spaced then show the error. Along with that how about we use the trim() function as well?

image

CC @jfrerich

@hanzei
Copy link
Contributor

hanzei commented Oct 26, 2021

@sibasankarnayak Can you please help with this question? ☝️

@sibasankarnayak
Copy link
Contributor

@hanzei I'm not sure about Server Side Changes, how about if we show a general error something like 'Input Cannot be Empty'

We can probablycheck if the input is only spaced then show the error. Along with that how about we use the trim() function as well?

image

CC @jfrerich

I feel having the restriction from client end will be much better .

@dipak-demansol
Copy link
Author

@sibasankarnayak @adithyaakrishna @hanzei may be simple solution will be to trim the space so we don't have to worry about handling the validation

@adithyaakrishna
Copy link

@dipak-demansol I am not sure if that would be the right approach as its something to deal with validation and IMO it should give proper messages always 😶

@cyrusjc
Copy link
Contributor

cyrusjc commented Apr 7, 2024

Hi I would like to pick up this issue.

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Apr 8, 2024
@hanzei
Copy link
Contributor

hanzei commented Apr 8, 2024

Thanks @cyrusjc 👍

mickmister pushed a commit that referenced this issue Apr 23, 2024
* validated issueTitle by removing leading/trailing space

* removed redundant bool type casting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants