-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request review and Pull request review comments not working #405
Comments
Hi @ecylmz, Thanks for the report. Would you be open on installing a custom version with additional logging? That would help with debuggin. |
Of course! How can i install the custom version you mentioned? |
Could you please DM me on the Mattermost Community Server? |
@ecylmz Thanks for the report. We are looking into this. Meanwhile I've send you the build via mail. |
@ecylmz I updated the total users limit for the team. Can you try again? |
@hanzei When i install the plugin, i get the following error:
@jwilander thanks. I joined. |
@hanzei I just installed the GitHub integration as part of an evaluation of Mattermost. My first test was with PRs since we have issues turned off in GitHub because we use Azure DevOps boards (as an aside I am able to get ADO to post into Mattermost using ADOs builtin Slack integration using a Matterport incoming webhook URL - nice!). What is the status of this bug? I don't see any response to @ecylmz post from two weeks ago. Is this still a known issue awaiting resolution? |
I believe so. I am using the cloud version of Mattermost. Just started with it so still very new. Can I install the custom version and see if that helps? |
Do any of the subscriptions work? I have subscribed to a repo in a channel for the default plus issue_comments and created a test issue in the repo. Nothing is showing up in Mattermost. The sidebar items for PRs, assignments and messages work but notifications are not showing up in a subscribed channel. |
Unfortunately you can't install a custom version of a plugin in MM cloud.
Any specified list of features does overwrite the default list. Could you please try again with |
|
{
"id": "web.incoming_webhook.text.app_error",
"message": "No text specified.",
"detailed_error": "",
"request_id": "zptosmuncty5jc1mjqq98ctfpa",
"status_code": 400
}
So, the error message is "No text specified". I have gone through the request JSON and I don't see any empty fields. Do we know what text (and property name) that Mattermost was expecting to see? |
@hanzei The Github integration is now working for issue comments. It looks like during my earlier experimentation and evaluation I entered the wrong webhook in the repository settings in GitHub. I just removed everything and started from scratch with https://github.com/mattermost/mattermost-plugin-github/blob/master/README.md. As someone brand new to Mattermost and the Mattermost GitHub integration I was not aware that there are two separate pieces which likely explains why I was seeing the correct GitHub information reflected in the sidebar, yet nothing was showing up in the subscribed channel. Also, the response message "No text specified" is misleading as it implies the connection is fine and the problem is within the payload. |
I can also verify that pull request comments are working for me as was the notification when my test PR was closed. |
The |
I upgraded Mattermost to 5.30.1 but still has issues installing a custom version of this plugin. Error:
|
Hello again, I upgraded Mattermost to version 5.34.2. I also upgraded this plugin to v2.0.1. The error is as follows:
|
Hi,
Pull request review and Pull request review comments not working for us. We have following error log on mattermost:
{"level":"warn","ts":1605265921.2438548,"caller":"mlog/sugar.go:27","msg":"Error webhook post","plugin_id":"github","error":"SqlPostStore.Save: İleti kaydedilemedi., pq: value too long for type character varying(26)"}
İleti kaydedilemedi
meansThe message could not be saved
This error maybe not related to this plugin.
My environment:
Webhook payload: https://gist.github.com/ecylmz/183cabab78939dc8bc0403b9bb7419b9
GitHub Plugin: (github - 2.0.0)
Mattermost server:
postgres (PostgreSQL) 12.4 (Debian 12.4-1.pgdg100+1)
What do you think could cause this error?
Thanks.
The text was updated successfully, but these errors were encountered: