Create GitHub Issue does not respect organization lock

[DHaussermann]

When the GitHub plugin is configured to be locked to an organization, this is not reflected in the create functionality. Users are still able to create issues in repos where they are owner, collaborators etc...
When the Organization is locked in the config, create should only allow connected users to create issues in this organization regardless of their individual permissions and memberships. This is already the case with the attach functionality.

Steps

• Lock the plugin to 1 Organization
• Connect as a user with permissions to create issues in multiple organizations
• Create a Github issue from a post

Observed Multiple orgs can be returned in the modal and the issue created

[hanzei]

I can't reproduce this issue with b1e3667.

Locking to an organisation correctly brings up only a list of repos that are part of that organisation.

Is it possible that you already opened the modal and then changed the organisation? Please note that changing the organisation setting takes a few seconds to "apply".

[AayushChaudhary0001]

@mickmister I tried to reproduce this bug with the multiple scenarios but was able to reproduce it once only.
Issue: This is the stale page case when user has opened the Mattermost website in two tabs on same window.

Steps to reproduce:

1. Go to the mattermost server and open it in two different tabs
2. On first tab of the Mattermost server open the 'Create Github issue' modal
3. Now switch to another tab of Mattermost server, lock the plugin to 1 Organization.
4. Save the changes and come back to the first tab of Mattermost where we initially opened the 'Create Github issue' modal
5. Check the Repository dropdown

Actual - User is still able to create issues in different repository
Expected - User should not be able to create issues in different repository other than the locked one

[raghavaggarwal2308]

@wiggin77 It is a very rare edge case. If we just re-open the modal the drop down will update. Do you think we should fix this?