Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the "Attach to Issue" feature, only show repos the user is a member or collaborator of #273

Open
mickmister opened this issue May 16, 2020 · 5 comments
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@mickmister
Copy link
Contributor

mickmister commented May 16, 2020

There is a digression between how the "Create Issue" and "Attach to Issue as Comment" features, in how they filter on which repos can be chosen, specifically when the plugin is not locked to an organization.

The "Create Issue" repos are scoped to repos that user is a member or collaborator of. The "Attach to Issue" repos display several public repos that the user has no affiliation with.

As discussed here, the user should only be able to use repos they are affiliated with. In order to accomplish this, we should have a repo select box to allow the user to select the repo first, then the issue selector should filter on that selected repo.

@mickmister mickmister added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Tech/Go Tech/ReactJS Difficulty/1:Easy Easy ticket Type/Enhancement New feature or improvement of existing feature labels May 16, 2020
@hanzei
Copy link
Contributor

hanzei commented May 16, 2020

I not sure if this is feasible with the GitHub API. /search/labels doesn't allow limiting the results by affliction.

One alterative way to implement this ticket is to check for every returned issue if the user can an affliction to the repo, but that seams like a lot of overhead.

I'm wondering if instead the flow should be changed to have the user first select a repo and then an issue of this repo.

@mickmister
Copy link
Contributor Author

I'm wondering if instead the flow should be changed to have the user first select a repo and then an issue of this repo.

👍 Updated description to reflect this @hanzei

@DHaussermann
Copy link

@mickmister I've also noticed that the create modal will not limit the user to creating issue to a specific organization when the organization is locked on the plugin config.
cc @aaronrothschild this creates an inconsistency between create and attach even when the plugin is configured to only use 1 organization.

@mickmister
Copy link
Contributor Author

@DHaussermann So it sounds like the attach functionality is working correctly in regards to scoping to an org. Do you mind creating an issue to adjust the create functionality to match this functionality?

@DHaussermann
Copy link

Created #285 to address the create issue as I realize now that this task is only for changes to attach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

5 participants