Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure myTeam.id is not undefined #8375

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Ensure myTeam.id is not undefined #8375

merged 1 commit into from
Nov 26, 2024

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Nov 26, 2024

Summary

With the amount of unions, filtering and mapping done in the team sidebar let's add some protective code to ensure the id is never undefined.

Ticket Link

N/A
Potential cherry-pick for 2.23

Release Note

NONE

@enahum enahum added 2: Dev Review Requires review by a core commiter CherryPick/Candidate A candidate for a quality or patch release, but not yet approved labels Nov 26, 2024
@enahum enahum requested review from larkox and crspeller November 26, 2024 04:24
@enahum enahum added the Build Apps for PR Build the mobile app for iOS and Android to test label Nov 26, 2024
@amyblais amyblais added this to the v2.23.0 milestone Nov 26, 2024
@amyblais amyblais added CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed CherryPick/Candidate A candidate for a quality or patch release, but not yet approved labels Nov 26, 2024
@enahum enahum merged commit 7123c7f into main Nov 26, 2024
44 checks passed
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@enahum enahum deleted the team-sidebar-undefined-fix branch November 26, 2024 12:15
mattermost-build pushed a commit that referenced this pull request Nov 26, 2024
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 26, 2024
amyblais pushed a commit that referenced this pull request Nov 26, 2024
(cherry picked from commit 7123c7f)

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core commiter Build Apps for PR Build the mobile app for iOS and Android to test CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants