Extra keyboard #8348
Merged
Extra keyboard #8348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
added
2: Dev Review
matthewbirtch
requested review from
abhijit-singh
and removed request for
matthewbirtch
abhijit-singh
added
the
Build Apps for PR
abhijit-singh
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Tested on Android and iPhone, looks good to me! Thanks @enahum.
larkox
reviewed
Nov 21, 2024
app/context/extra_keyboard/index.tsx
Outdated
Comment on lines
72
to
77
| const registerTextInputFocus = useCallback(() => { | ||
| setIsTextInputFocused(true); | ||
| setTimeout(() => { | ||
| setExtraKeyboardVisible(false); | ||
| }, 400); | ||
| }, []); |
There was a problem hiding this comment.
I don't completely understand why the extra keyboard sets visible to false when the input is focused. Is it a mistake, or I am missing something?
There was a problem hiding this comment.
Ah.. yes this one is tricky.. in short is a hack to handle the fact that the Android Keyboard when receiving focus will cause an animation glitch if the extra keyboard was already opened.
There was a problem hiding this comment.
Since this is one is tricky, I think we should add some comment to explain why we do this.
larkox
approved these changes
Nov 25, 2024
|
This also fixes https://mattermost.atlassian.net/browse/MM-61917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the KeyboardTrackingView used to track the keyboard on the post list for iOS as well as adds functionality to change the adjust behavior on Android.
With the two above taken care of, now our app will no longer move the contents of the screen (aka post list) on both Android and iOS when giving focus to the draft input. Instead we are adding a View below the draft input that will animate its height to the keyboard height, moving the contents of the screen upwards (this works fine even when using a hardware keyboard).
Additionally, we have the ability to set a custom component where the keyboard is displayed to accommodate for things like the emoji picker and in the future if we want the image picker and others.
Ticket Link
https://mattermost.atlassian.net/browse/MM-61739
https://mattermost.atlassian.net/browse/MM-61551
https://mattermost.atlassian.net/browse/MM-61917
Checklist
Device Information
This PR was tested on:
iPhone 14
iPhone SE
iPhone 16 Pro
iPad 11
iPad 13 Max
Emulators for Android 14 and 15 including foldable devices
Release Note