Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animate gif as default until MM-22242 is implemented #8339

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Animate gif as default until MM-22242 is implemented #8339

merged 1 commit into from
Nov 13, 2024

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Nov 13, 2024

Summary

Revert so that gifs are animated by default

Ticket Link

N/A

Release Note

NONE

@enahum enahum added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 13, 2024
@enahum enahum added this to the v2.22.0 milestone Nov 13, 2024
@amyblais amyblais modified the milestones: v2.22.0, v2.23.0 Nov 13, 2024
@enahum enahum removed the 2: Dev Review Requires review by a core commiter label Nov 13, 2024
@enahum enahum merged commit 6e032a7 into main Nov 13, 2024
28 checks passed
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@enahum enahum deleted the animate-gif branch November 13, 2024 11:17
mattermost-build pushed a commit that referenced this pull request Nov 13, 2024
@enahum @mattermost-build
Animate gif as default until MM-22242 is implemented (#8339)
d9635f6 
(cherry picked from commit 6e032a7)
@mattermost-build mattermost-build mentioned this pull request Nov 13, 2024
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 13, 2024
@enahum
Copy link
Contributor Author

enahum commented Nov 13, 2024

@amyblais any reason why not to cherry pick this to 2.22 as well?

@amyblais
Copy link
Member

/cherry-pick release-2.22

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit that referenced this pull request Nov 13, 2024
@enahum @mattermost-build
Animate gif as default until MM-22242 is implemented (#8339)
3c28aa1 
(cherry picked from commit 6e032a7)
@mattermost-build mattermost-build mentioned this pull request Nov 13, 2024
Merged
amyblais pushed a commit that referenced this pull request Nov 13, 2024
@mattermost-build @enahum
Animate gif as default until MM-22242 is implemented (#8339) (#8341)
2554cd5 
(cherry picked from commit 6e032a7)

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
amyblais pushed a commit that referenced this pull request Nov 13, 2024
@mattermost-build @enahum
Animate gif as default until MM-22242 is implemented (#8339) (#8342)
0e3c813 
(cherry picked from commit 6e032a7)

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asaadmahmood asaadmahmood asaadmahmood approved these changes

@rahimrahman rahimrahman rahimrahman approved these changes

@iyampaul iyampaul Awaiting requested review from iyampaul

Assignees
No one assigned
Labels
CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone release-note-none
Projects
None yet
Milestone
v2.23.0
Development

Successfully merging this pull request may close these issues.
6 participants
@enahum @mattermost-build @amyblais @rahimrahman @asaadmahmood @mm-cloud-bot