Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove warning due to patch version missmatch #8332

Merged
merged 1 commit into from
Nov 13, 2024
Merged

remove warning due to patch version missmatch #8332

merged 1 commit into from
Nov 13, 2024

Conversation

Willyfrog
Copy link
Contributor

Summary

After updating to main, I got a warning of patch version mismatch

I tried the suggested patch package, but that generated a ton of differences that might not be relevant (mostly binary changes 🤷🏼 ), so I just renamed the file.

NONE

@Willyfrog Willyfrog added the 2: Dev Review Requires review by a core commiter label Nov 12, 2024
@Willyfrog Willyfrog requested a review from enahum November 12, 2024 15:37
@rahimrahman rahimrahman self-requested a review November 12, 2024 15:50
@enahum enahum added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 13, 2024
@enahum enahum merged commit f6bc8ae into main Nov 13, 2024
32 of 36 checks passed
@enahum enahum deleted the remove_patch_warning branch November 13, 2024 00:05
@enahum enahum mentioned this pull request Nov 13, 2024
Merged
@enahum
Copy link
Contributor

enahum commented Nov 13, 2024

/cherry-pick release-2.23.0

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@mattermost-build
Copy link
Contributor

Error trying doing the automated Cherry picking. Please do this manually

+++ Updating remotes...
Fetching upstream
hostfile_replace_entries: mkstemp: Read-only file system
update_known_hosts: hostfile_replace_entries failed for /app/.ssh/known_hosts: Read-only file system
From github.com:mattermost/mattermost-mobile
 + 99190fac1...8843ddc18 fastlane   -> upstream/fastlane  (forced update)
Fetching upstream
hostfile_replace_entries: mkstemp: Read-only file system
update_known_hosts: hostfile_replace_entries failed for /app/.ssh/known_hosts: Read-only file system
+++ Updating remotes done...
!!! 'upstream/release-2.23.0' not found. The second argument should be something like upstream/release-0.21.
    (In particular, it needs to be a valid, existing remote branch that I can 'git checkout'.)

+++ Returning you to the master branch and cleaning up.

@enahum
Copy link
Contributor

enahum commented Nov 13, 2024

/cherry-pick release-2.23

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit that referenced this pull request Nov 13, 2024
@Willyfrog @mattermost-build
remove warning due to patch version missmatch (#8332)
53edbd6 
(cherry picked from commit f6bc8ae)
@mattermost-build mattermost-build mentioned this pull request Nov 13, 2024
Merged
@mattermost-build mattermost-build added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Nov 13, 2024
enahum pushed a commit that referenced this pull request Nov 13, 2024
@mattermost-build @Willyfrog
remove warning due to patch version missmatch (#8332) (#8336)
ad46cec 
(cherry picked from commit f6bc8ae)

Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enahum enahum enahum approved these changes

@rahimrahman rahimrahman rahimrahman approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Willyfrog @enahum @mattermost-build @rahimrahman @mm-cloud-bot