fix bookmarks sort order when WS does not bump update_at #8264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
approved these changes
Oct 16, 2024
calebroseland
approved these changes
Oct 16, 2024
enahum
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When sorting the channel bookmarks on the webapp, the WS event was not changing the update_at property of the objects
We are now also updating the local records if the
sort_orderhas changed to fix the sorting updates while the server does not have the changes included in mattermost/mattermost#28807Ticket Link
https://mattermost.atlassian.net/browse/MM-60644
Server PR
mattermost/mattermost#28807
Release Note