Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Auth Scheme customization on build time #8261

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Oct 15, 2024

Summary

The authentication schemes were hardcoded to use mmauthbeta for our Beta app and mmauth for our release app. While the server allows this schemes to be changed in order to be used with custom mobile builds, the mobile app did not have a way to easily customize them, having to make some changes in the code before compiling.

This PR introduces a couple of environment variables to be able to change these authentication schemes on build time.

Note: This is backwards compatible so that the app builds the same way as before if no env var is set.

Ticket Link

N/A.

Release Note

NONE

@enahum enahum added the 2: Dev Review Requires review by a core commiter label Oct 15, 2024
Copy link
Member

@mvitale1989 mvitale1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Elias!

@enahum enahum merged commit 8c7c02d into main Oct 23, 2024
20 checks passed
@enahum enahum deleted the authScheme branch October 23, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core commiter release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants