Remove axios and detox from package.json in the root folder #8219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasserfaraazkhan
added
E2E iOS tests for PR
esarafianou
approved these changes
Sep 13, 2024
yasserfaraazkhan
approved these changes
Sep 13, 2024
jwilander
approved these changes
Sep 13, 2024
larkox
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Remove axios and detox from package.json in the root folder * fix ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the dev dependencies for axios and detox are not really needed in the root project but only in the detox folder. this will help with future dependency scans to not being flagged.
Also updated the deps for detox.
Ticket Link
N/A
Release Note