Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Fixes #8212

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Various Fixes #8212

merged 6 commits into from
Sep 12, 2024

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Sep 11, 2024

Summary

This PR fixes a few things

  • iOS was blocking the UI when rendering a video thumbnail (library patched)
  • Gallery was rendering the wrong dimensions for video / image on iPad after a change in orientation or splitting the screen
  • Upgrade fastlane to resolve the warning with rexml
  • Upgrade path-to-regex to solve a security warning.
  • Fix the ChannelBookmark component ref

Ticket Link

N/A

Release Note

NONE

@enahum enahum added 2: Dev Review Requires review by a core commiter 3: Security Review Review requested from Security Team labels Sep 11, 2024
@esarafianou esarafianou self-requested a review September 12, 2024 08:59
esarafianou
esarafianou approved these changes Sep 12, 2024
View reviewed changes
Copy link

@esarafianou esarafianou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@esarafianou esarafianou removed the 3: Security Review Review requested from Security Team label Sep 12, 2024
@esarafianou esarafianou removed the request for review from enzowritescode September 12, 2024 08:59
@calebroseland calebroseland requested review from sbishel and removed request for calebroseland September 12, 2024 15:34
@enahum enahum merged commit 394da44 into main Sep 12, 2024
36 checks passed
@enahum enahum deleted the fixes branch September 12, 2024 20:46
@amyblais amyblais modified the milestones: v2.21.0, v2.22.0 Sep 13, 2024
larkox pushed a commit that referenced this pull request Oct 11, 2024
@enahum @larkox
Various Fixes (#8212)
2c541df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esarafianou esarafianou esarafianou approved these changes

@sbishel sbishel sbishel approved these changes

@larkox larkox larkox approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core commiter release-note-none
Projects
None yet
Milestone
v2.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@enahum @larkox @sbishel @esarafianou @amyblais @mm-cloud-bot