Fix iPad split view #8199
Merged
Fix iPad split view #8199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
added
2: Dev Review
lindalumitchell
added
the
Build Apps for PR
larkox
approved these changes
Sep 3, 2024
rahimrahman
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Q: do we need this file anymore? Still referring to isSplitView but should have been isSplit. But it feels like all the type def is in the rnutils/src/index.tsx.
https://github.com/mattermost/mattermost-mobile/blob/main/types/global/device.d.ts#L8
rahimrahman
approved these changes
Sep 3, 2024
lindalumitchell
approved these changes
Sep 4, 2024
larkox
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Fix iPad split view * remove unused type def
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Split View on iPad
Ticket Link
https://mattermost.atlassian.net/browse/MM-60365
Release Note