Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update network-client to fix ssl error #8194

Merged
merged 1 commit into from
Aug 30, 2024
Merged

update network-client to fix ssl error #8194

merged 1 commit into from
Aug 30, 2024

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Aug 30, 2024

Summary

Fixes the error message on Android for invalid SSL certs

Ticket Link

https://mattermost.atlassian.net/browse/MM-60325

Release Note

NONE

@enahum enahum added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Aug 30, 2024
@enahum
Copy link
Contributor Author

enahum commented Aug 30, 2024

@amyblais this is the second part of the fix

@enahum enahum added the Build Apps for PR Build the mobile app for iOS and Android to test label Aug 30, 2024
@amyblais amyblais added this to the v2.20.0 milestone Aug 30, 2024
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Aug 30, 2024
@amyblais
Copy link
Member

@larkox @rahimrahman Please help prioritize reviews on this one too.

lindalumitchell
lindalumitchell approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@lindalumitchell lindalumitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified fix on Android build and double-checked still works as expected on iOS build. LGTM!

@amyblais amyblais added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Aug 30, 2024
@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Aug 30, 2024
@amyblais amyblais merged commit ad54f53 into main Aug 30, 2024
52 checks passed
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@amyblais amyblais deleted the update-net branch August 30, 2024 17:35
mattermost-build pushed a commit that referenced this pull request Aug 30, 2024
@enahum @mattermost-build
update network-client to fix ssl error (#8194)
32eeaf8 
(cherry picked from commit ad54f53)
@mattermost-build mattermost-build mentioned this pull request Aug 30, 2024
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 30, 2024
amyblais pushed a commit that referenced this pull request Aug 30, 2024
@mattermost-build @enahum
update network-client to fix ssl error (#8194) (#8195)
850c5b7 
(cherry picked from commit ad54f53)

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
larkox pushed a commit that referenced this pull request Oct 11, 2024
@enahum @larkox
update network-client to fix ssl error (#8194)
1e110bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindalumitchell lindalumitchell lindalumitchell approved these changes

@rahimrahman rahimrahman rahimrahman approved these changes

@larkox larkox larkox approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Build Apps for PR Build the mobile app for iOS and Android to test CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone QA Review Done release-note-none
Projects
None yet
Milestone
v2.20.0
Development

Successfully merging this pull request may close these issues.
7 participants
@enahum @amyblais @mattermost-build @larkox @rahimrahman @lindalumitchell @mm-cloud-bot