fix sso login success message #8174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
added
2: Dev Review
enahum
commented
Aug 26, 2024
| @@ -151,6 +151,7 @@ export type CallsConnection = { | |||
|
|
|||
| export type CallsConfigState = CallsConfig & { | |||
| AllowEnableCalls: boolean; | |||
| GroupCallsAllowed: boolean; | |||
There was a problem hiding this comment.
@cpoile for some reason TS was complaining
jwilander
approved these changes
Aug 26, 2024
| @@ -151,6 +151,7 @@ export type CallsConnection = { | |||
|
|
|||
| export type CallsConfigState = CallsConfig & { | |||
| AllowEnableCalls: boolean; | |||
| GroupCallsAllowed: boolean; | |||
There was a problem hiding this comment.
Nevermind, I see your other comment
rahimrahman
reviewed
Aug 26, 2024
| doSSOLogin(bearerToken, csrfToken); | ||
| } | ||
| } else if (Platform.OS === 'ios' || result.type === 'dismiss') { | ||
| } else if (Platform.OS === 'ios' && result.type === 'dismiss') { |
There was a problem hiding this comment.
@enahum if on Android, and user "dismiss" or (x) out of Okta sso, would this if logic change miss that user?
There was a problem hiding this comment.
@rahimrahman yes thank you, this was unintended.
|
/update-branch |
rahimrahman
approved these changes
Aug 27, 2024
enahum
added
4: Reviews Complete
|
For future traceability: https://mattermost.atlassian.net/browse/MM-60293 |
|
/cherry-pick release-2.20 |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
that referenced
this pull request
Aug 27, 2024
* fix sso login success message * fix if statement --------- Co-authored-by: Mattermost Build <build@mattermost.com> (cherry picked from commit 8b869c2)
mattermost-build
added
the
CherryPick/Done
amyblais
pushed a commit
that referenced
this pull request
Aug 27, 2024
|
/cherry-pick release-2.19 |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
that referenced
this pull request
Aug 27, 2024
* fix sso login success message * fix if statement --------- Co-authored-by: Mattermost Build <build@mattermost.com> (cherry picked from commit 8b869c2)
mattermost-build
added a commit
that referenced
this pull request
Aug 27, 2024
…mobile-#8174-upstream-release-2.19
amyblais
pushed a commit
that referenced
this pull request
Aug 27, 2024
larkox
pushed a commit
that referenced
this pull request
Oct 11, 2024
* fix sso login success message * fix if statement --------- Co-authored-by: Mattermost Build <build@mattermost.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a transitional screen when the SSO is successful
Ticket Link
https://hub.mattermost.com/private-core/pl/55xw79opufn6jrzawkuzrrxjtc
Checklist
E2E iOS tests for PR.Screenshots
Release Note