Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit tests for app/utils/navigation #8139

Merged
merged 1 commit into from
Aug 28, 2024
Merged

add unit tests for app/utils/navigation #8139

merged 1 commit into from
Aug 28, 2024

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Aug 12, 2024

Summary

Adds code coverage to 100% for app/utils/navigation

image

Ticket Link

https://mattermost.atlassian.net/browse/MM-59572

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Release Note

NONE

@enahum enahum added the 2: Dev Review Requires review by a core commiter label Aug 12, 2024
@enahum enahum requested review from larkox and jwilander August 12, 2024 06:47
@enahum enahum added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Aug 28, 2024
@enahum enahum merged commit 2174c67 into main Aug 28, 2024
22 checks passed
@enahum enahum deleted the MM-59572 branch August 28, 2024 16:03
larkox pushed a commit that referenced this pull request Oct 11, 2024
@enahum @larkox
add unit tests for app/utils/navigation (#8139)
22326e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilander jwilander jwilander approved these changes

@larkox larkox larkox approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enahum @larkox @jwilander @mm-cloud-bot