Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies #8131

Merged
merged 4 commits into from
Aug 12, 2024
Merged

update dependencies #8131

merged 4 commits into from
Aug 12, 2024

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Aug 6, 2024

Summary

Update project depedencies.

@enzowritescode, @coltoneshaw as part of this updates we modified expo-images to remove the dependency on libdav1d as we do not make use of it.

Ticket Link

N/A

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Release Note

NONE

@enahum enahum added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Aug 6, 2024
@saturninoabril saturninoabril added the E2E iOS tests for PR Run iOS E2E Detox tests label Aug 6, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Aug 6, 2024
saturninoabril
saturninoabril approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM (tests passed), except for one request.

test/setup.ts Outdated Show resolved Hide resolved
@larkox
Copy link
Contributor

larkox commented Aug 8, 2024

Does the android lockfile needs updating?

@enahum
Copy link
Contributor Author

enahum commented Aug 8, 2024

Does the android lockfile needs updating?

@larkox no changes on the android deps.. deleting the lock files and regenerating them show no changes.

@enahum enahum added 4: Reviews Complete All reviewers have approved the pull request Build Apps for PR Build the mobile app for iOS and Android to test and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester 4: Reviews Complete All reviewers have approved the pull request labels Aug 8, 2024
@enahum enahum merged commit 0b83938 into main Aug 12, 2024
20 checks passed
@enahum enahum deleted the deps branch August 12, 2024 06:15
@licaon-kter licaon-kter mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahimrahman rahimrahman rahimrahman approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

@larkox larkox larkox approved these changes

@enzowritescode enzowritescode enzowritescode approved these changes

Assignees
No one assigned
Labels
Build Apps for PR Build the mobile app for iOS and Android to test release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@enahum @larkox @enzowritescode @saturninoabril @rahimrahman @mm-cloud-bot