Upgrade RN as well as update or replace other dependencies #8011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SplitView modules with new arch support
larkox
reviewed
Jun 13, 2024
package.json
Outdated
| "react-native-walkthrough-tooltip": "1.6.0", | ||
| "react-native-webrtc": "111.0.6", | ||
| "react-native-webview": "13.8.4", | ||
| "react-native-webrtc": "124.0.0", |
There was a problem hiding this comment.
@cpoile I know the last time I tried to update react-native-webrtc you had some concerns about it. You may want to check if there is any library update done here that you may want reverted before we merge this.
There was a problem hiding this comment.
yes please do check @cpoile
larkox
approved these changes
Jun 17, 2024
...ies/@mattermost/rnutils/android/src/main/java/com/mattermost/rnutils/helpers/RealPathUtil.kt
Outdated
Show resolved
Hide resolved
|
@cpoile @larkox I'll be merging this PR so that it can be included in the 2.19 release.. if we find anything causing problems we can always open another PR to fix it. @rahimrahman FYI as now we will need to use node 20 |
This was referenced Jun 24, 2024
fewva
pushed a commit
to fewva/mattermost-mobile
that referenced
this pull request
Jul 4, 2024
…attermost#8011)" This reverts commit b8c088c.
|
@enahum The Release Note says "Need to add some release notes at the end" - can you help fill in the missing release notes? |
|
no release notes needed really |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a long PR that is aiming to not only upgrade react native but also lay the ground work to start using the new architecture, this is being held back at the moment by the navigation library there is a draft PR in the works.
Part of this PR updates some libraries, replaces others with maintained ones and there are 4 local libraries as well.
Probably the easiest way to review the PR is by looking at the individual commits.
Here a list of the replaced libraries:
Replaced libraries
@rneui/baseas this is the same but renamed up to date libraryRemoved libraries
Upgrade to Node 20+
Upgrade cocoapods to 1.15.2
upgrade bundler to 2.5.11
upgraded fastlane
upgraded all other dependencies
Checklist
Device Information
This PR was tested on: iOS similators and device as well as Android
Release Note