Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel Bookmarks #7817

Merged
merged 44 commits into from
Jul 18, 2024
Merged

Channel Bookmarks #7817

merged 44 commits into from
Jul 18, 2024

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Feb 6, 2024

Summary

This PR adds the channel bookmarks to mobile

In order to use it needs a server running mattermost/mattermost#25449

Ticket Link

https://mattermost.atlassian.net/browse/MM-54432

Added channel bookmarks

This is the same as #7750

@enahum enahum added the 2: Dev Review Requires review by a core commiter label Feb 6, 2024
@yasserfaraazkhan yasserfaraazkhan added Build Apps for PR Build the mobile app for iOS and Android to test and removed Build Apps for PR Build the mobile app for iOS and Android to test labels Feb 7, 2024
@jupenur
Copy link
Member

jupenur commented Feb 7, 2024

@enahum you need to reapply the changes or do some other magic to make it possible to review this. Currently there are 0 changed files since the whole thing was already merged.

@enahum
Copy link
Contributor Author

enahum commented Feb 8, 2024

/update-branch

@enahum
Copy link
Contributor Author

enahum commented Feb 8, 2024

@jupenur that was weird.. anyway, did a rebase locally and force pushed the changes,.. now it all seems to be ok in that respect

@enahum enahum requested a review from esarafianou July 1, 2024 23:11
@enahum enahum added the 3: Security Review Review requested from Security Team label Jul 1, 2024
@enahum
Copy link
Contributor Author

enahum commented Jul 1, 2024

@esarafianou added you as a reviewer for security, feel free to add someone else if you think is best.

sbishel
sbishel approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several reviews here as well
#7750

@enahum enahum merged commit b330847 into main Jul 18, 2024
12 checks passed
@enahum enahum deleted the bookmarks branch July 18, 2024 01:10
@enahum
Copy link
Contributor Author

enahum commented Jul 18, 2024

Ok given the lift I went ahead and merged

@amyblais amyblais added this to the v2.20.0 milestone Jul 18, 2024
@amyblais amyblais added the Docs/Needed Requires documentation label Jul 26, 2024
@cwarnermm cwarnermm mentioned this pull request Oct 8, 2024
Merged
@cwarnermm cwarnermm added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbishel sbishel sbishel approved these changes

@calebroseland calebroseland calebroseland approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core commiter 3: Security Review Review requested from Security Team Docs/Done Required documentation has been written release-note
Projects
None yet
Milestone
v2.20.0
Development

Successfully merging this pull request may close these issues.
8 participants
@enahum @jupenur @calebroseland @sbishel @yasserfaraazkhan @amyblais @mm-cloud-bot @cwarnermm