Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries and dependencies #7678

Merged
merged 13 commits into from
Nov 24, 2023
Merged

Update libraries and dependencies #7678

merged 13 commits into from
Nov 24, 2023

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Nov 22, 2023

Summary

Updates libraries and dependencies including RN to 0.72.7 and WatermelonDB this last one includes breaking changes so we need to update the imports.

Release Note

NONE

@enahum enahum added the 2: Dev Review Requires review by a core commiter label Nov 22, 2023
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and calls still works. Though I think I'd want Dylan to do a more thorough smoke test if there's a chance this could break things.

@enahum enahum requested a review from DHaussermann November 22, 2023 22:09
@enahum enahum added the 3: QA Review Requires review by a QA tester label Nov 22, 2023
@enahum
Copy link
Contributor Author

enahum commented Nov 22, 2023

Tested and calls still works. Though I think I'd want Dylan to do a more thorough smoke test if there's a chance this could break things.

Added @DHaussermann as requested

@@ -39,7 +39,7 @@
{
"rule": "cli",
"binary": "pod",
"semver": "1.12.1",
"semver": "1.14.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Mainly a few question to satisfy my curiosity.

The only thing that may require changes is the way we are handling the new image style for fast image, but 0/5

app/components/emoji/emoji.tsx Outdated Show resolved Hide resolved
app/components/progressive_image/index.tsx Outdated Show resolved Hide resolved
patches/react-native-haptic-feedback+2.0.3.patch Outdated Show resolved Hide resolved
@enahum
Copy link
Contributor Author

enahum commented Nov 24, 2023

@cpoile I'm going to merge the PR and let @DHaussermann test on his own time.. I think you did a smoke test and this PR is large enough. If anything comes up, let me know so I can help.

@enahum enahum removed the 2: Dev Review Requires review by a core commiter label Nov 24, 2023
@enahum enahum merged commit edef4ec into main Nov 24, 2023
1 check passed
@enahum enahum deleted the deps branch November 24, 2023 23:46
@amyblais amyblais added this to the v2.12.0 milestone Nov 27, 2023
fewva pushed a commit to fewva/mattermost-mobile that referenced this pull request Jan 12, 2024
* update js dependencies

* update react-native libraries

* update watermelonDB

* update RN to 0.72.7

* update fastlane

* fix remove_markdown/at_mention import

* update mattermost libraries

* update fastlane deps

* remove haptic-feedback patch

* update okhttp to 4.12.0 and patch netinfo to accurately identify VPN connections

* create ImaegStyles intersection type
cyrusjc pushed a commit to cyrusjc/mattermost-mobile that referenced this pull request May 18, 2024
* update js dependencies

* update react-native libraries

* update watermelonDB

* update RN to 0.72.7

* update fastlane

* fix remove_markdown/at_mention import

* update mattermost libraries

* update fastlane deps

* remove haptic-feedback patch

* update okhttp to 4.12.0 and patch netinfo to accurately identify VPN connections

* create ImaegStyles intersection type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants