Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-48825] - Move search results number text below tab button #7339

Closed
wants to merge 1 commit into from

Conversation

nevyangelova
Copy link

@nevyangelova nevyangelova commented May 9, 2023

Summary

This PR submits a fix for the cases when there are lots of files and messages and the Files tab extends into the filter icon.
It moves the text below into the Results screen as proposed by UX

Ticket Link

https://mattermost.atlassian.net/browse/MM-48225

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.

Device Information

This PR was tested on: iPhone 8, iOS 15.2 / Pixel 3a, Android 12.1

Screenshots

Screenshot 2023-05-09 at 14 35 36

Screenshot 2023-05-09 at 14 35 43

Release Note

NONE

@nevyangelova nevyangelova requested review from enahum and AshishDhama May 9, 2023 07:39
@nevyangelova nevyangelova added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels May 9, 2023
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Lifecycle/1:stale release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants