Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds muted state to channel list in sidebar #6042

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

shaz-r
Copy link
Contributor

@shaz-r shaz-r commented Mar 9, 2022

Summary

Checks if a channel is muted, and if so - lowers the opacity to 0.4

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-42159

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.

Device Information

This PR was tested on:

Screenshots

Release Note


@shaz-r shaz-r self-assigned this Mar 9, 2022
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small improvements can be made

@@ -73,6 +74,9 @@ const getStyleSheet = makeStyleSheetFromTheme((theme: Theme) => {
groupInfo: {
color: theme.centerChannelColor,
},
muted: {
opacity: 0.4,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 0.5 as in v1?

@@ -180,7 +190,7 @@ const ChannelIcon = ({
}

return (
<View style={[styles.container, {width: size, height: size}, style]}>
<View style={[styles.container, {width: size, height: size}, style, mutedStyle]}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can combine all this into ine style with useMemo

Base automatically changed from gekidou-categories-item-sorted to gekidou March 10, 2022 21:19
@enahum enahum added the 4: Reviews Complete All reviewers have approved the pull request label Mar 11, 2022
@enahum enahum merged commit eec536a into gekidou Mar 11, 2022
@enahum enahum deleted the MM-42159-Sidebar-Channel-List-Muted branch March 11, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants