-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds muted state to channel list in sidebar #6042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small improvements can be made
@@ -73,6 +74,9 @@ const getStyleSheet = makeStyleSheetFromTheme((theme: Theme) => { | |||
groupInfo: { | |||
color: theme.centerChannelColor, | |||
}, | |||
muted: { | |||
opacity: 0.4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 0.5 as in v1?
@@ -180,7 +190,7 @@ const ChannelIcon = ({ | |||
} | |||
|
|||
return ( | |||
<View style={[styles.container, {width: size, height: size}, style]}> | |||
<View style={[styles.container, {width: size, height: size}, style, mutedStyle]}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can combine all this into ine style with useMemo
Summary
Checks if a channel is muted, and if so - lowers the opacity to 0.4
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-42159
Checklist
Device Information
This PR was tested on:
Screenshots
Release Note