Gekidou - Account Screen #5708
Merged
Gekidou - Account Screen #5708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 7, 2021 20:23
avinashlng1080
added
the
Do Not Merge
|
There will be a final PR that will polish the UI both on mobile and on tablet |
added 9 commits
October 8, 2021 13:03
This reverts commit 5defc31.
|
@enahum : Can you please start the review? |
enahum
approved these changes
Oct 12, 2021
avinashlng1080
removed
the
Do Not Merge
|
@enahum - The PR is looking great. Thanks for the amendments. I would like to merge it into the Gekidou branch given it's quite bulky. I guess that why you assigned it to me, but please let me know if I can proceed with the merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR caters for the Account screen on Gekidou/V2.
It will be used as a
mainfeature branch and each sub-feature pertaining to the Account screen(e.g Saved messages, Profile, Settings) will have a separate PR created and merged into this one.Once approved, it will be merged into Gekidou.
We can start with the review
Release Note