Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gekidou] server_url and theme context #5540

Merged
merged 1 commit into from
Jul 14, 2021
Merged

[Gekidou] server_url and theme context #5540

merged 1 commit into from
Jul 14, 2021

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Jul 13, 2021

Summary

Add Context for ServerUrl and Theme with Providers, HOC's and Hooks

Release Note

NONE

@enahum enahum added the 2: Dev Review Requires review by a core commiter label Jul 13, 2021
@enahum enahum requested a review from avinashlng1080 July 13, 2021 18:58
avinashlng1080
avinashlng1080 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@avinashlng1080 avinashlng1080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; apart from the one comment.

app/context/theme/index.tsx Show resolved Hide resolved
@enahum enahum added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jul 14, 2021
@enahum enahum merged commit 2dc37f1 into gekidou Jul 14, 2021
@enahum enahum deleted the context branch July 14, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinashlng1080 avinashlng1080 avinashlng1080 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enahum @avinashlng1080 @mm-cloud-bot