Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate react-native-network-client #5499

Merged
merged 56 commits into from
Jul 6, 2021
Merged

Integrate react-native-network-client #5499

merged 56 commits into from
Jul 6, 2021

Conversation

migbot
Copy link
Contributor

@migbot migbot commented Jun 29, 2021

Summary

Release Note

NONE

@migbot migbot added the 2: Dev Review Requires review by a core commiter label Jun 29, 2021
@migbot migbot requested review from enahum and avinashlng1080 June 29, 2021 04:23
migbot
migbot commented Jun 29, 2021
View reviewed changes
app/init/network_manager.ts Outdated Show resolved Hide resolved
app/init/network_manager.ts Show resolved Hide resolved
app/init/network_manager.ts Outdated Show resolved Hide resolved
app/init/network_manager.ts Outdated Show resolved Hide resolved
app/client/rest/base.ts Outdated Show resolved Hide resolved
app/requests/remote/push_notification.ts Outdated Show resolved Hide resolved
app/screens/server/index.tsx Outdated Show resolved Hide resolved
app/screens/sso/index.tsx Outdated Show resolved Hide resolved
app/screens/sso/sso_with_webview.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
enahum
enahum requested changes Jun 30, 2021
View reviewed changes
app/actions/remote/general.ts Outdated Show resolved Hide resolved
app/actions/remote/general.ts Outdated Show resolved Hide resolved
app/actions/remote/systems.ts Show resolved Hide resolved
app/actions/remote/user.ts Outdated Show resolved Hide resolved
app/actions/remote/user.ts Outdated Show resolved Hide resolved
patches/react-native-keychain+7.0.0.patch Show resolved Hide resolved
app/init/network_manager.ts Outdated Show resolved Hide resolved
app/init/network_manager.ts Show resolved Hide resolved
app/init/network_manager.ts Outdated Show resolved Hide resolved
app/init/network_manager.ts Outdated Show resolved Hide resolved
@enahum
Copy link
Contributor

enahum commented Jun 30, 2021

There are some linting errors as well

enahum added 24 commits July 2, 2021 10:09
@enahum
Merge branch 'gekidou' into gekidou-network-clients
cccc182
@enahum
cleanup user actions
f839c80
@enahum
Fix NetworkManager invalidate client
c77e2ca
@enahum
Invalidate client when server screen appears
be26b45
@enahum
Update kotlin to 1.4.30 required by network-client
4b23310
@enahum
patch react-native-keychain to remove cached credential
ce22a29
@enahum
update react-native-network-client
ba70408
@enahum
Use app.db instead of default.db in native code
181d65e
@enahum
fix use of rnnc on Android
e98f55f
@enahum
Init PushNotifications
beeac73
@enahum
No need to reset serverVersion on logout
cd150ff
@enahum
fix logout action
e8bc57a
@enahum
fix deleteServerDatabase
b674ac3
@enahum
fix schedule expired session notification
899048f
@enahum
use safeParseJSON for db json fields
56fcd51
@enahum
unsubscribe when database component unmounts
a516413
@enahum
cleanup init
5bed596
@enahum
session type
0f0cb39
@enahum
pass launchprops to entire login flow
efa867f
@enahum
Properly remove third party cookies after SSO login
ef0469c
@enahum
recreate network client if sso with redirect fails
2c3cb7b
@enahum
add missing launch props from server screen
81ca9db
@enahum
use query prefix for database queries
d730ce9
@enahum
Add temporary logout function to channel screen
57017e6
enahum
enahum approved these changes Jul 3, 2021
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avinashlng1080 please review

@enahum enahum marked this pull request as ready for review July 3, 2021 23:06
avinashlng1080
avinashlng1080 approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@avinashlng1080 avinashlng1080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future or in this PR, the Network manager can benefit from a test script.

@enahum enahum removed the 2: Dev Review Requires review by a core commiter label Jul 6, 2021
@enahum enahum merged commit 134c4a4 into gekidou Jul 6, 2021
@enahum enahum deleted the gekidou-network-clients branch July 6, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anurag6713 anurag6713 anurag6713 left review comments

@avinashlng1080 avinashlng1080 avinashlng1080 approved these changes

@enahum enahum enahum approved these changes

Assignees
No one assigned
Labels
release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@migbot @enahum @anurag6713 @avinashlng1080 @mm-cloud-bot