Add getMostRecentServerUrl function

[migbot]

In the init process I need to know what the active server URL is. I extracted out querying of that value into getMostRecentServerUrl and then used that function in getMostRecentServerDatabase which used to be called getMostRecentServerConnection. There's more work to be done here (like tests and mocks) but wanted your thoughts. Regarding the term "connection" in the previous method, I'd rather use "database" as that's what is actually being returned. Regarding the term "most recent", I think we should use "active" instead, at least in the functions here. More broadly, maybe we can get rid of the RECENTLY_VIEWED_SERVERS and instead add some timestamp field (ie, lastViewed) to the Server model. We could then query for active server.

[mm-cloud-bot]

@migbot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

[mm-cloud-bot]

@migbot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

[enahum]

I like the idea about having a timestamp, but we should also track if the user is logged in or not. I can see how that will be more beneficial than the current implementation, as it would allow us to select the db we want based on the timestamps and it will also be easier to maintain.

Do we want to merge this in the meantime while we do the necesary changes?

[migbot]

@avinashlng1080 Can I merge as is and would you be able to take care of the changes for tests as well as adding a timestamp field to the Server model?

[avinashlng1080]

In the init process I need to know what the active server URL is. I extracted out querying of that value into getMostRecentServerUrl and then used that function in getMostRecentServerDatabase which used to be called getMostRecentServerConnection. There's more work to be done here (like tests and mocks) but wanted your thoughts.

I updated the code before looking at this PR. The getMostRecentServerConnection is returning an object of { connection, serverUrl}

Regarding the term "connection" in the previous method, I'd rather use "database" as that's what is actually being returned. Regarding the term "most recent", I think we should use "active" instead, at least in the functions here.

Let's agree on the final naming conventions to be used and I will rename them.

More broadly, maybe we can get rid of the RECENTLY_VIEWED_SERVERS and instead add some timestamp field (ie, lastViewed) to the Server model. We could then query for active server.

Yes I can tackle this one and it is a better solution. It will impact the schema, model, database manager and data operators/handlers. We'll need to update this value each time the user switches server.

To merge this PR?

Let's see first if you can use the refactored method.

[migbot]

/release-note-none

[avinashlng1080]

Apart from that one comment, the PR is good. I also tested manually on simulator and verified if the databases were being created and populated.

[migbot]

Assuming that Avinash would approve after the small typo fix. Going to merge now so I can get the gekidou-init branch finalized.