Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use us-east-1c as default AZ #817

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Use us-east-1c as default AZ #817

merged 2 commits into from
Oct 1, 2024

Conversation

streamer45
Copy link
Contributor

Summary

Defaulting on us-east-1c since it was proven to work, while others may have issues (especially 1a and 1b).

Still undecided on whether we should force the default if unset (empty). Let me know if you have any thoughts.

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Oct 1, 2024
@streamer45 streamer45 self-assigned this Oct 1, 2024
Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still undecided on whether we should force the default if unset (empty).

If people explicitly unset it, then I'd say it's safe to assume it's for a good reason.

@streamer45
Copy link
Contributor Author

Still undecided on whether we should force the default if unset (empty).

If people explicitly unset it, then I'd say it's safe to assume it's for a good reason.

We just don't know if they did it explicitly right? :p It's fine, I want to assume everyone will hear our announcements :)

@streamer45
Copy link
Contributor Author

somehow pipeline is failing 🤔

@streamer45
Copy link
Contributor Author

@agarciamontoro TestTerraformMapString was flaky as we can't assume the ordering of map keys. I fixed the test as I am not sure we need to go as far as sorting the output but will leave that decision to you.

@streamer45 streamer45 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 1, 2024
@streamer45 streamer45 merged commit 7a51b55 into master Oct 1, 2024
1 check passed
@streamer45 streamer45 deleted the fix-default-az branch October 1, 2024 16:55
@agarciamontoro
Copy link
Member

Congratulations, @streamer45, you just fixed https://mattermost.atlassian.net/browse/MM-60725 🎉 😂

@agarciamontoro
Copy link
Member

I'm ok with the solution, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants