Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformed Prometheus configuration YAML file #816

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

agarciamontoro
Copy link
Member

Summary

It seems that #807 stole the static_configs: line from the cloudwatch section and gave it to the netpeek one 😈

Ticket Link

--

@agarciamontoro agarciamontoro added the 2: Dev Review Requires review by a core committer label Sep 30, 2024
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's slightly out of scope, but can I ask this string to be templatized like nginxSiteConfigTmpl? The %ss are starting to get out of hand and becoming very brittle as is apparent with this break.

Hopefully, it's not too much of work.

Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to merge that a few times to get it right, and, of course, something got messed up. We should probably have some basic parsing tests on these config files. I can look into it, but I don't want to delay the fix.

@agarciamontoro
Copy link
Member Author

I know it's slightly out of scope, but can I ask this string to be templatized like nginxSiteConfigTmpl? The %ss are starting to get out of hand and becoming very brittle as is apparent with this break.

We should probably have some basic parsing tests on these config files.

Both comment seems sensible to me. I'd say we merge this now and I can tackle those improvements later.

@agarciamontoro
Copy link
Member Author

Ticket created: https://mattermost.atlassian.net/browse/MM-60726

@agnivade agnivade added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 1, 2024
@agarciamontoro agarciamontoro merged commit 3c37207 into master Oct 1, 2024
1 check passed
@agarciamontoro agarciamontoro deleted the fix.malformed.yaml branch October 1, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants