Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VPC claiming for external cluster types #1064

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

gabrieljackson
Copy link
Contributor

In an effort to support EKS clusters in our standard production AWS accounts, this change allows for importing clusters with VPC claiming. Clusters imported in this way will be able to perform AWS resource lookups to manage installations with pgbouncer, bifrost, and similar dependencies.

This is example metadata for an external cluster with a claimed VPC:

        "ID": "k5mk7fr1k3r8tmi46dbbf5wj6w",
        "State": "stable",
        "Provider": "external",
        "ProviderMetadataExternal": {
            "HasAWSInfrastructure": true
        },
        "Provisioner": "external",
        "ProvisionerMetadataExternal": {
            "Name": "k5mk7fr1k3r8tmi46dbbf5wj6w-external-k8s",
            "SecretName": "kubeconfig-net-calico",
            "Version": "1.29.4-eks-036c24b",
            "VPC": "vpc-0846s82b132aad7e7",
            "Warnings": [
                "Health Check: failed to find any deployments in namespace bifrost"
            ]
        },

A follow-up PR will be needed to incorporate new VPC lookup filters so that kops clusters can't accidentally claim a VPC with EKS clusters in them.

Fixes https://mattermost.atlassian.net/browse/CLD-7985

Add VPC claiming for external cluster types

In an effort to support EKS clusters in our standard production
AWS accounts, this change allows for importing clusters with VPC
claiming. Clusters imported in this way will be able to perform
AWS resource lookups to manage installations with pgbouncer,
bifrost, and similar dependencies.
@gabrieljackson gabrieljackson added 2: Dev Review Requires review by a developer 2: Infra Review Requires review by a SRE kind/feature Categorizes issue or PR as related to a new feature. labels Jul 22, 2024
@mm-cloud-bot mm-cloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 22, 2024
@gabrieljackson gabrieljackson marked this pull request as ready for review July 22, 2024 17:44
@andrleite
Copy link
Contributor

@gabrieljackson nice work on this! One question. So for now, Will we only check for the most important utilities and put a warning in case they don't exist? Bifrost isn't in argo for example, will this warning block cluster from receiving installations?

Copy link
Contributor

@nickmisasi nickmisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gabrieljackson
Copy link
Contributor Author

One question. So for now, Will we only check for the most important utilities and put a warning in case they don't exist? Bifrost isn't in argo for example, will this warning block cluster from receiving installations?

@andrleite yep, currently the logic is warn and proceed for utilities. We can tweak this in the future if we like as well as add more checks, but we may need to get some testing in on this behavior to see what will work best for us.

@gabrieljackson gabrieljackson added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer 2: Infra Review Requires review by a SRE labels Jul 24, 2024
@gabrieljackson gabrieljackson merged commit 4756386 into master Jul 24, 2024
5 checks passed
@gabrieljackson gabrieljackson deleted the external-vpc-claiming branch July 24, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants