Skip to content

Used Claude code to refactor #7929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

Used Claude code to refactor #7929

wants to merge 27 commits into from
+2,700 −446

Conversation

sadohert
Copy link
Contributor

@sadohert sadohert commented May 7, 2025

Sub pages were added. Claude seemed to expand on the documentation for calls configuration, including deployment, metrics monitoring, RTC setup, and troubleshooting.

@sadohert sadohert marked this pull request as ready for review May 7, 2025 16:35
@sadohert sadohert self-assigned this May 7, 2025
@sadohert sadohert requested a review from cwarnermm May 7, 2025 16:37
@sadohert sadohert mentioned this pull request May 7, 2025
Closed
@sadohert sadohert requested a review from streamer45 May 7, 2025 17:06
@sadohert
Copy link
Contributor Author

sadohert commented May 7, 2025

@streamer45 @cwarnermm - You can ignore this for the moment. I'm just trying to get it to publish a preview environment so i can look at how things lay out from the Claude Code changes. I'm not sure why I can't get this PR to build a preview

@cwarnermm cwarnermm added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label May 7, 2025
@cwarnermm
Copy link
Member

Ah, I do, @sadohert. It's because it's a fork, not a branch. Only branches (via authorized users) trigger automated previews. For forks, we need to add the preview environment label to kick these off (each time a commit is made). Happy to monitor and help ensure the label is applied as needed so that you can see the pages as intended in production.

@cwarnermm cwarnermm added the Work In Progress Not yet ready for review label May 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

Newest code from sadohert has been published to preview environment for Git SHA d0ee389

@cwarnermm
Copy link
Member

@sadohert - Preview now available.

@sadohert sadohert added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels May 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

Newest code from sadohert has been published to preview environment for Git SHA 0a722e5

@sadohert sadohert marked this pull request as draft May 13, 2025 13:17
@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Jun 11, 2025
@github-actions GitHub Actions
Copy link

Newest code from sadohert has been published to preview environment for Git SHA 39abca9

@sadohert
Copy link
Contributor Author

I'm transitioning these back to markdown. My bad. I thought RST was the standard we were moving to.

I'll also resolve the merge conflict.

sadohert added 11 commits June 11, 2025 14:15
@sadohert
Used Claude code to refactor
7a7e43e 
Sub pages were added. Claude seemed to expand on the documentation for
calls configuration, including deployment, metrics monitoring,
RTC setup, and troubleshooting.
@sadohert
Refactored Kubernetes content to a separate page.
37b72ef 
I'm concerned about the degree of 'hallucination` on some of the K8s/Helm config that Claude came up with
@sadohert
Listing TODOs. Some minor tweaks.
ba97a32 
Getting the working directory committed to start using Claude to go through the TODOs.
@sadohert
Added Calls Offloader logs
b9ea56d
@sadohert
Added bottom navigation to get to all sections
87874da
@sadohert
Add toctree for sidebar navigation
2a8d052
@sadohert
Removed Claude's extrapolation to COTURN config
d7336da
@sadohert
Clean up from review and validation
af0d121
@sadohert
Expanded API connectivity testing instructions
d905c69
@sadohert
Removed reference to job service secret
cd176e5 
We don't really talk about it enough in the docs anyway.  Leave that for another revision
@sadohert
Added plugin restart guidance when configuring offloader
60b03a3
@sadohert sadohert force-pushed the stu-calls-claude-05-07 branch from a1d3830 to 304864a Compare June 11, 2025 18:40
@sadohert sadohert added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Jun 11, 2025
@github-actions GitHub Actions
Copy link

Newest code from sadohert has been published to preview environment for Git SHA 304864a

sadohert and others added 3 commits June 11, 2025 16:12
@sadohert
Adapting the nav structure
ae4507f 
Mixing of rst and markdown caused issues with the LHS navigation
@cwarnermm
Fixed nav structure, moved Ent badge, applied build fixes
2bd46aa
@sadohert
Fixing navigation breaks
52cc483 
From MD to RST to MD transition
@sadohert sadohert added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Jun 11, 2025
@github-actions GitHub Actions
Copy link

Newest code from sadohert has been published to preview environment for Git SHA 52cc483

@sadohert
Copy link
Contributor Author

TODOs:

  • Remove RTCD pprof configuration
  • Ensure references to Prometheus setup always have the label
  • Verify all "Getting Starting" docs within the RTCD and Offloader "Getting STarted" pages are reflected in the docs, then modify the projects to point to the docs (for a single source of truth)
  • Modify the Calls dashboard to include new constants for Offloader and RTCD OS Metrics ports (default 9100)

@sadohert @claude
Add air-gap Docker registry setup for Calls offloader
f04ded0 
Enhanced calls documentation with comprehensive air-gapped deployment guidance:
- Added Docker registry setup overview to calls-deployment.md
- Added detailed air-gap configuration section to calls-offloader-setup.md
- Includes setup scripts, manual configuration, verification, and troubleshooting
- Addresses Docker image requirements for recording and transcription services

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@sadohert sadohert added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Jun 14, 2025
@github-actions GitHub Actions
Copy link

Newest code from sadohert has been published to preview environment for Git SHA f04ded0

1 similar comment
@github-actions GitHub Actions
Copy link

Newest code from sadohert has been published to preview environment for Git SHA f04ded0

@sadohert @claude
Replace script references with direct Docker commands in air-gap setup
182ebcc 
Removed references to non-existent setup scripts and replaced with:
- Direct Docker commands for registry setup and image management
- Manual configuration steps instead of script dependencies
- Concrete examples for custom registry hosts and image versions

Makes the air-gap setup more reliable and self-contained.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@sadohert sadohert added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Jun 14, 2025
@github-actions GitHub Actions
Copy link

Newest code from sadohert has been published to preview environment for Git SHA f04ded0

1 similar comment
@github-actions GitHub Actions
Copy link

Newest code from sadohert has been published to preview environment for Git SHA f04ded0

@sadohert sadohert added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Jun 22, 2025
@github-actions GitHub Actions
Copy link

Newest code from sadohert has been published to preview environment for Git SHA 700d283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm Awaiting requested review from cwarnermm

@streamer45 streamer45 Awaiting requested review from streamer45

At least 1 approving review is required to merge this pull request.

Assignees

@sadohert sadohert

Labels
preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories Work In Progress Not yet ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sadohert @cwarnermm