Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Mattermost-supported plugins to product docs #7030

Merged
merged 32 commits into from
May 9, 2024

Conversation

cwarnermm
Copy link
Member

@cwarnermm cwarnermm commented Apr 3, 2024

Documentation for: #7005

GitHub repository README updates to de-duplicate content is managed via separate PRs:

Separate PRs are being created to manage all in-product docs links currently taking users to GH READMEs, and take them to product docs instead.

The Google Calendar plugin documentation has been migrated from the Mattermost Product Documentation to its GitHub repository README via: mattermost/mattermost-plugin-google-calendar#74

Note: Legal Hold config docs & the new v2 Survey Plugin docs will be consolidated into the Mattermost Product Documentation in a future iteration. The existing User Satisfaction Survey docs will also be reviewed and aligned in a future iteration.

@cwarnermm cwarnermm added the Work In Progress Not yet ready for review label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA 7f717c8

@cwarnermm cwarnermm mentioned this pull request Apr 12, 2024
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 272c695

Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA b063d03

Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 26bd302

Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA b40771e

Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 702196f

Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 36f370d

Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 2046a3b

hanzei
hanzei previously requested changes Apr 22, 2024
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @cwarnermm 👍

Once this PR is merged, should we update the plugin metadata so the Marketplace entries point to the docs pages? Should we also remove the duplicate information from the respective READMEs?

* :doc:`GitLab interoperability </integrate/gitlab-interoperability>` - Connect your GitLab instance to your Mattermost instance.
* :doc:`Jira interoperability </integrate/jira-interoperability>` - Connect your Jira instance to your Mattermost instance.
* :doc:`Legal hold
* :doc:`Performance metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should move the Metrics plugin out of this category. It's not an integration, but more of a tool. It's more like "Calls" and less like the "GitHub" plugin.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a really good point, @hanzei, and I agree with your classification of the Metrics plugin. Legal hold and channel export would also fall into this category. Perhaps the way forward is to include only the interoperability plugins here. Tool-based integrations would be documented as any other product feature. Will think on this more. Really appreciate your input here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Features built as plugins are documented like features; 3rd party interoperability integrations are collected together, in the docs, under Integrate & Extend from the landing page.

I agree that we'll want to update the plugin metadata so the Marketplace entries point to the docs pages -- both the in-product Marketplace as well as the external one via mm.com/marketplace. These tasks will be completed outside of this PR.

source/guides/integrate-and-extend.rst Outdated Show resolved Hide resolved
@@ -1619,8 +1423,8 @@ In addition to the Mattermost plugin signing key built into the server, each pub
| This feature's ``config.json`` setting is ``"SignaturePublicKeyFiles": {}`` with string array input consisting of contents that are relative or absolute paths to signature files. |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

.. config:setting:: plugins-zoomchimeraoauthproxyurl
:displayname: Chimera OAuth proxy URL (Plugins - Zoom)
.. config:setting:: plugins-chimeraoauthproxyurl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unclear to me which plugin these belong to and when an admin should modify these values. Can we clarify that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code highlighted is metadata used to return config settings in search results.

I agree that the Chimera OAuth proxy URL docs don't specify which integrations this config affects, and we can definitely add this. Can you confirm which integrations utilize this config setting, please?

source/collaborate/extend-mattermost-with-integrations.rst Outdated Show resolved Hide resolved
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 7ad7a36

@cwarnermm
Copy link
Member Author

/update-branch

mattermost-build and others added 2 commits April 24, 2024 22:49
* Update conf.py

* Clarified that system roles also control access to related API endpoints (#6901)

* Clarified that system roles include related API endpoints

* Update source/onboard/system-admin-roles.rst

Co-authored-by: Eva Sarafianou <eva.sarafianou@gmail.com>

---------

Co-authored-by: Eva Sarafianou <eva.sarafianou@gmail.com>

* Added new error codes page (#6908)

* Remove legacy MySQL references (#6896)

* Removed legacy references to MySQL v5.x

* Added missing redirect

* Removed "Sync" to align with product naming (#6898)

* Clarified Ent/Pro differentiation (#6899)

* Clarified that bots don't count as active users (#6902)

* Added interactive demo link (#6905)

* Added link to Kubernetes YAML docs via mattermost repo (#6906)

* Clarified supported AllowCorsFrom values (#6897)

* Updated legacy E10/E20 label text (#6900)

* Updated legacy E10/E20 label text

* Add example for E10/E20 label setup

* Test markup for labels

* Another markup test for labels

* And another markup test for labels

* Use raw html markup for E10/E20 labels

* Updated styling for legacy E10/E20 labels

* Change class name

---------

Co-authored-by: emdecr <delacruz.emily@gmail.com>

* Added transcription end user docs (#6910)

* Added Metrics plugin

* Update source/scale/performance-monitoring.rst

* Removed HA modes details

* dashboards-how-to (#6935)

* dashboards-how-to

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Split perf monitoring into 3 parts: 3rd party integrations, plugin, & metrics

* Incorporated reviewer feedback

* Update source/guides/scale-mattermost.rst

Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>

* Update source/guides/scale-mattermost.rst

Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>

* Incorporated reviewer feedback, added redirects, & updated links

* Fixed broken link

---------

Co-authored-by: Amy Blais <29708087+amyblais@users.noreply.github.com>
Co-authored-by: Eva Sarafianou <eva.sarafianou@gmail.com>
Co-authored-by: emdecr <delacruz.emily@gmail.com>
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Copy link

Newest code from mattermost-build has been published to preview environment for Git SHA 7bd0b2d

Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 4dddf1a

Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 8b4ab5a

Copy link

github-actions bot commented May 8, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA 94ed1e9

Copy link

github-actions bot commented May 8, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA 2f4c7cb

Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @cwarnermm!! Crazy how much attention to detail this took, migrating markdown to rst alone is quite the task, and organizing it all this way with everything working 👏

LGTM 🚀

source/integrate/zoom-interoperability.rst Show resolved Hide resolved
.. include:: ../_static/badges/allplans-cloud-selfhosted.rst
:start-after: :nosearch:

.. |product-menu| image:: ../images/products_E82F.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the file's name can be made more human-readable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those filenames come directly from the mattermost/compass-icons GH repository. I've matched the filename convention in the hopes of finding a way to automate the inclusion of these icons in docs some day.

source/guides/integrate-and-extend.rst Outdated Show resolved Hide resolved
source/guides/integrate-and-extend.rst Outdated Show resolved Hide resolved
source/comply/export-mattermost-channel-data.rst Outdated Show resolved Hide resolved
source/integrate/jira-interoperability.rst Outdated Show resolved Hide resolved
source/integrate/jira-interoperability.rst Outdated Show resolved Hide resolved
source/integrate/jira-interoperability.rst Show resolved Hide resolved
source/integrate/servicenow-interoperability.rst Outdated Show resolved Hide resolved
cwarnermm and others added 2 commits May 8, 2024 15:54
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Copy link

github-actions bot commented May 8, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA 159cda1

Copy link

github-actions bot commented May 8, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA 1355e9b

Copy link

github-actions bot commented May 9, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA 2324697

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter Work In Progress Not yet ready for review labels May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA d84ac27

@cwarnermm cwarnermm merged commit cf302c5 into master May 9, 2024
4 checks passed
@cwarnermm cwarnermm deleted the mattermost-supported-integrations branch May 9, 2024 19:39
Copy link

github-actions bot commented May 9, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA a2acbaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants