Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #75

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Fix CI #75

merged 1 commit into from
Oct 29, 2020

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Oct 27, 2020

Summary

Fix broken CI caused by #74

Ticket Link

Follow up on #74

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Oct 27, 2020
@hanzei hanzei added this to the v1.3.0 milestone Oct 27, 2020
@hanzei hanzei requested a review from jfrerich October 27, 2020 12:43
@jfrerich
Copy link
Contributor

Thanks, @hanzei. I'm good merging this without QA.

@jfrerich jfrerich removed the 2: Dev Review Requires review by a core committer label Oct 27, 2020
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Oct 29, 2020
@hanzei hanzei merged commit 60d7beb into master Oct 29, 2020
@hanzei hanzei deleted the fix_lint branch October 29, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrerich jfrerich jfrerich approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hanzei @jfrerich