Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dependencies to use github.com/mattermost/mattermost-server/v5 #61

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Jun 22, 2020

Summary

A community member did run into an issue using github.com/mattermost/mattermost-server instead of github.com/mattermost/mattermost-server/v5. This PR updated the dependencies to use github.com/mattermost/mattermost-server/v5.

Ticket Link

None

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 22, 2020
@hanzei hanzei added this to the v1.3.0 milestone Jun 22, 2020
@hanzei hanzei requested review from iomodo and jfrerich June 22, 2020 15:22
@codecov-commenter
Copy link

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   29.48%   29.48%           
=======================================
  Files           8        8           
  Lines         234      234           
=======================================
  Hits           69       69           
  Misses        153      153           
  Partials       12       12           
Impacted Files Coverage Δ
server/plugin.go 4.83% <ø> (ø)
server/util/util.go 40.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea56bb...2a40bc2. Read the comment docs.

Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @hanzei

@iomodo iomodo removed the 2: Dev Review Requires review by a core committer label Jun 22, 2020
@hanzei
Copy link
Collaborator Author

hanzei commented Jun 22, 2020

Skipping QA review as it's only a dependency update

@hanzei hanzei merged commit 05cc4cf into master Jun 22, 2020
@hanzei hanzei deleted the mm_v5 branch June 22, 2020 16:54
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants