-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-58502 Error on crossing block limit on client side #5015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshilsharma63
requested changes
Jun 13, 2024
hmhealey
reviewed
Jun 13, 2024
Rajat-Dabade
changed the title
[MM-58502]: Error on crossing block limit on client side
MM-58502 Error on crossing block limit on client side
Jun 18, 2024
harshilsharma63
approved these changes
Jun 26, 2024
hmhealey
approved these changes
Jun 26, 2024
yasserfaraazkhan
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified uploading plugin to 9.10.0 server. The expected error is display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://mattermost.atlassian.net/browse/MM-58502
This PR implements a client-side check for the block limit on the card. Instead of failing silently without any error message, the front end will display an error if the block limit is exceeded.
User flow:
Screen.Recording.2024-06-12.at.8.41.12.PM.mov
I also updated the
mysql/mysql-server
docker version because version5.7.12
was deprecated.