Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-58502 Error on crossing block limit on client side #5015

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

Rajat-Dabade
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade commented Jun 12, 2024

Fixes: https://mattermost.atlassian.net/browse/MM-58502

This PR implements a client-side check for the block limit on the card. Instead of failing silently without any error message, the front end will display an error if the block limit is exceeded.

User flow:

  • An error will be shown if the user crosses the block limit on the client side.
  • Error will persist if the user loses the focus from the block and no API call will be made.
  • If users close the card with an error then the data will be lost.
Screen.Recording.2024-06-12.at.8.41.12.PM.mov

I also updated the mysql/mysql-server docker version because version 5.7.12 was deprecated.

@Rajat-Dabade Rajat-Dabade self-assigned this Jun 13, 2024
@Rajat-Dabade Rajat-Dabade added the 2: Dev Review Requires review by a core committer label Jun 13, 2024
@Rajat-Dabade Rajat-Dabade added the 2: QA Review Requires review by a QA tester label Jun 13, 2024
@Rajat-Dabade Rajat-Dabade changed the title [MM-58502]: Error on crossing block limit on client side MM-58502 Error on crossing block limit on client side Jun 18, 2024
@hmhealey hmhealey removed the 2: Dev Review Requires review by a core committer label Jun 26, 2024
Copy link

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified uploading plugin to 9.10.0 server. The expected error is display.

@Rajat-Dabade Rajat-Dabade merged commit 1932acb into main Aug 7, 2024
18 checks passed
@Rajat-Dabade Rajat-Dabade deleted the client-block-limit branch August 7, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants