-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI after mono-repo #4669
Merged
Merged
Fix CI after mono-repo #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgdelacroix
force-pushed
the
test-fix-main-after-mono-repo
branch
from
March 27, 2023 13:40
af3309e
to
5ba51fc
Compare
wiggin77
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
sbishel
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
/cherry-pick release-7.8 |
Cherry pick is scheduled. |
Error trying doing the automated Cherry picking. Please do this manually
|
mgdelacroix
added a commit
that referenced
this pull request
Mar 29, 2023
mgdelacroix
added a commit
that referenced
this pull request
Mar 29, 2023
mgdelacroix
added a commit
that referenced
this pull request
Mar 29, 2023
mgdelacroix
added a commit
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the default
mattermost-server
reference to be pulled if a test run doesn't have a branch on the server repo. The reference now points to the commit pre-mono-repo, so the code can build and test can run normally.This fixes CI for
main
and for the PRs of both new fixes and cherry-picks to the release branches we're still maintaining