Fixed the hover issue for sub-menu for card attachment #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajat-Dabade
added
1: UX Review
asaadmahmood
requested changes
Jan 20, 2023
There was a problem hiding this comment.
Unfortunately, I did not have a look at this issue carefully. I have sent @Rajat-Dabade a video on the expected behaviour.
|
/update-branch |
harshilsharma63
requested changes
Feb 6, 2023
| @@ -122,8 +122,18 @@ const AttachmentElement = (props: Props): JSX.Element|null => { | |||
| document.body.removeChild(anchor) | |||
| } | |||
|
|
|||
| const handleMouseLeave = () => { | |||
There was a problem hiding this comment.
Hmm, DOM manipulation is an expensive operation. I suppose you're doing this to remove focus from something? There must be a better way for this.
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the closing of the sub-menu when hovering out the file attachment.
Ticket Link
Fixes #4374