Updates migrations to check collation/charset before trying to fix it #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbishel
approved these changes
Dec 13, 2022
sbishel
added
the
CherryPick/Approved
wiggin77
reviewed
Dec 13, 2022
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/focalboard
that referenced
this pull request
Dec 13, 2022
…mattermost-community#4325) * Updates migrations to check collation/charset before trying to fix it * Update server/services/store/sqlstore/data_migrations.go Co-authored-by: Doug Lauder <wiggin77@warpmail.net> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> Co-authored-by: Doug Lauder <wiggin77@warpmail.net> (cherry picked from commit f2d98f9)
mattermod
added
CherryPick/Done
sbishel
pushed a commit
that referenced
this pull request
Dec 13, 2022
…#4325) (#4331) * Updates migrations to check collation/charset before trying to fix it * Update server/services/store/sqlstore/data_migrations.go Co-authored-by: Doug Lauder <wiggin77@warpmail.net> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> Co-authored-by: Doug Lauder <wiggin77@warpmail.net> (cherry picked from commit f2d98f9) Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
mgdelacroix
added a commit
that referenced
this pull request
Dec 19, 2022
…#4325) * Updates migrations to check collation/charset before trying to fix it * Update server/services/store/sqlstore/data_migrations.go Co-authored-by: Doug Lauder <wiggin77@warpmail.net> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR obtains the collation and charset of the
Boardstables and only fixes them if necessary. Currently it maintains the approach of fixing the issue automatically, but I'm happy to update it to notify the admin instead if that's the consensus.