Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a check that errors on store start if MariaDB is detected #3725

Merged
merged 4 commits into from
Aug 24, 2022

Conversation

mgdelacroix
Copy link
Contributor

Summary

These changes causes the app to error on start if the database is detected to be MariaDB

@mgdelacroix mgdelacroix added 2: Dev Review Requires review by a core committer CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 23, 2022
@wiggin77
Copy link
Contributor

@mgdelacroix this feels like we're telling customers MariaDB is officially dropped as an unofficially supported database. In other words, we're saying if you're on MariaDB you can't use Mattermost going forward. Is that really what we want?

@sbishel
Copy link
Collaborator

sbishel commented Aug 23, 2022

We already say that here - https://docs.mattermost.com/install/software-hardware-requirements.html#database-software

MariaDB v10+ no longer functions as a MySQL drop-in replacement, and it’s not supported for Mattermost due to the requirement of MySQL 5.7.12. Prior versions of MariaDB were not officially supported but may have functioned in older Mattermost releases. If you are running MariaDB now, migrating from MariaDB to the MySQL equivalent is recommended.

@mgdelacroix
Copy link
Contributor Author

We could tone down the error to say something less "radical" like this version of Boards doesn't support MariaDB if preferred, and even add a link to the code debt item, so users will know that we plan to make an effort to remove the non-compatible code.

The effect will still be that Boards is not going to work as of now, but they'll have a pointer to follow besides the error message.

@wiggin77
Copy link
Contributor

and even add a link to the code debt item,

@mgdelacroix I guess adding the link sbishel posted (https://docs.mattermost.com/install/software-hardware-requirements.html#database-software) would give the user some info.

@mgdelacroix
Copy link
Contributor Author

Error message updated on 59d6739

@sbishel
Copy link
Collaborator

sbishel commented Aug 24, 2022

/update-branch

@sbishel sbishel merged commit e1a39e5 into main Aug 24, 2022
@sbishel sbishel deleted the error-if-mariadb branch August 24, 2022 20:36
@sbishel sbishel added this to the v7.2 milestone Aug 24, 2022
@sbishel
Copy link
Collaborator

sbishel commented Aug 24, 2022

/cherry-pick release-7.2

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Aug 24, 2022
…rmost-community#3725)

* Adds a check that errors on store start if MariaDB is detected

* Fix linter

* Update error message

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
(cherry picked from commit e1a39e5)
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 24, 2022
mgdelacroix added a commit that referenced this pull request Aug 24, 2022
#3737)

* Adds a check that errors on store start if MariaDB is detected

* Fix linter

* Update error message

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
(cherry picked from commit e1a39e5)

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants