-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Calendar card "..." action menu overlapping behind adjacent cards #3486
Conversation
@Pinjasaur Wouldn't a better solution be just to add a class to the card who's menu is open, and then just increase the z-index on it? I think we can then also use that functionality to make sure that the menu remains even if you hover outside of that card, and only remove that class on a blur event or on a click outside. |
@asaadmahmood We don't have a lot of control over how the Calendar view is rendered since it's mostly done by the Full Calendar library component. I went the I think your idea is worth exploring, but perhaps as part of #1007 since it might also solve that same issue that bug is tracking. Let me know your thoughts—we're looking to get this for 7.2 or otherwise revert the functionality of the "..." menu (on Calendar view cards) for the release since it's broken as-is. #3425 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now.
Cherry pick is scheduled. |
mattermost-community#3486) (cherry picked from commit d653047)
Summary
This PR
unset
s somez-index
values that Full Calendar sets to prevent the "..." action menu from being overlapped by adjacent events in Calendar view.I went through a couple iterations to get to this solution, but it ended up being the last "hacky" (subjectively) even though it is overriding CSS from a vendored dependency. For some context, other "solutions" I tried:
@for
loop to set descending:nth-child
z-index
values e.g. https://stackoverflow.com/a/36609688Before:
After:
Ticket Link
closes #3425