Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logic to add board member to my memberships is it is for me #3388

Merged
merged 6 commits into from
Aug 3, 2022
Merged

Added logic to add board member to my memberships is it is for me #3388

merged 6 commits into from
Aug 3, 2022

Conversation

harshilsharma63
Copy link
Member

Fixes #3294

@harshilsharma63 harshilsharma63 requested a review from a team as a code owner July 20, 2022 06:33
@harshilsharma63 harshilsharma63 requested review from Pinjasaur, Rajat-Dabade, mgdelacroix, jespino and a team and removed request for a team, Pinjasaur and Rajat-Dabade July 20, 2022 06:33
@sbishel sbishel added 2: Dev Review Requires review by a core committer CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jul 26, 2022
@sbishel sbishel added this to the v7.2 milestone Jul 26, 2022
@harshilsharma63 harshilsharma63 requested a review from jespino August 1, 2022 08:08
jespino
jespino approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pinjasaur
Pinjasaur approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@Pinjasaur Pinjasaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harshilsharma63!

@Pinjasaur Pinjasaur merged commit 1e1854a into main Aug 3, 2022
@Pinjasaur Pinjasaur deleted the new-board-in-shidebar branch August 3, 2022 22:12
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Aug 3, 2022
@harshilsharma63 @mattermost-build
Added logic to add board member to my memberships is it is for me (ma…
61d05de 
…ttermost-community#3388)

(cherry picked from commit 1e1854a)
@mattermost-build mattermost-build mentioned this pull request Aug 3, 2022
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 3, 2022
sbishel pushed a commit that referenced this pull request Aug 4, 2022
@mattermost-build @harshilsharma63
Added logic to add board member to my memberships is it is for me (#3388
e9ef370 
) (#3539)

(cherry picked from commit 1e1854a)

Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pinjasaur Pinjasaur Pinjasaur approved these changes

@jespino jespino jespino approved these changes

@mgdelacroix mgdelacroix Awaiting requested review from mgdelacroix

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Milestone
v7.2
Development

Successfully merging this pull request may close these issues.

Bug: New membership not reflected live
5 participants
@harshilsharma63 @mattermod @jespino @Pinjasaur @sbishel